hrynko / vue-pdf-embed

PDF embed component for Vue 2 and Vue 3
https://npmjs.com/package/vue-pdf-embed
MIT License
707 stars 109 forks source link

Implement Vue 2 support for v2. #238

Open gkweb opened 1 week ago

gkweb commented 1 week ago

Vue 2 support is still possible with some very very minor changes.

Are you open to supporting both?

I'd be happy to open a PR. This might see the folder structure change slightly to support both versions of Vue gracefully.

hrynko commented 1 week ago

Hi @gkweb,

Support for Vue 2 was not envisaged in v2, and frankly, I don't see a way to support both Vues in the current environment. If you do, I'd be happy to check out your PR.

gkweb commented 1 week ago

@hrynko - Rough proposal before I spend any time there. See detail and let me know your thoughts?

Workspaces set up in the repo

Vue 2 in workspace will sit in @vue-pdf-embed/vue2

And consumed when published to npm via vue-pdf-embed/vue2/* Vue 3 is consumed as normal under: vue-pdf-embed/*

proposed folder change:

gkweb commented 1 day ago

Friendly bump of that proposal @hrynko - thoughts?