Open gkweb opened 1 week ago
Hi @gkweb,
Support for Vue 2 was not envisaged in v2
, and frankly, I don't see a way to support both Vues in the current environment. If you do, I'd be happy to check out your PR.
@hrynko - Rough proposal before I spend any time there. See detail and let me know your thoughts?
Workspaces set up in the repo
Vue 2 in workspace will sit in
@vue-pdf-embed/vue2
And consumed when published to npm via vue-pdf-embed/vue2/*
Vue 3 is consumed as normal under: vue-pdf-embed/*
proposed folder change:
toValue
to unref
MaybeRef
(doesn't exist for vue 2).packages/vue2/dist
OR workspace root /dist/vue2
TBC
Vue 2 support is still possible with some very very minor changes.
Are you open to supporting both?
I'd be happy to open a PR. This might see the folder structure change slightly to support both versions of Vue gracefully.