hsousa / HCSStarRatingView

Simple star rating view for iOS written in Objective-C
MIT License
1.28k stars 194 forks source link

bitcode problem #27

Closed iVanPan closed 8 years ago

iVanPan commented 8 years ago

i got this error, “HCSStarRatingView.framework/HCSStarRatingView' was built without full bitcode. All frameworks and dylibs for bitcode must be generated from Xcode Archive or Install build for architecture armv7 clang: error: linker command failed with exit code 1 (use -v to see invocation)” please support bitcode

rad182 commented 8 years ago

+1

hsousa commented 8 years ago

Can anyone provide me with a sample project of this happening?

Os steps to reproduce, so I can figure out what's going on. :smiley:

rad182 commented 8 years ago

I was able to make this work fine when archiving and submitting to app store with this workaround. Adding HCSStarRatingView.framework in Linked Frameworks and Libraries

screen shot 2015-10-29 at 7 45 32 pm
hsousa commented 8 years ago

Ok, that's the workaround. What do I have to do to break it? Is the error happening when you compile, when you archive or when you submit to Apple? Were you including the project directly, using CocoaPods or Carthage?

iVanPan commented 8 years ago

i got this error when i archive

iVanPan commented 8 years ago

i am using Carthage

rad182 commented 8 years ago

@hsousa mine was after uploading to itunesconnect

hsousa commented 8 years ago

Thanks guys! I'm going to try to figure out what might be going on when I have some time.

Until then I suggest using @rad182's workaround.

iVanPan commented 8 years ago

@hsousa i think it's Carthage's Bug https://github.com/Carthage/Carthage/issues/535 .I am installed last release (0.9.4) https://github.com/Carthage/Carthage/releases/tag/0.9.4 and the problem fixed

nlabhart commented 8 years ago

@rad182 did you add the framework, and remove the library from Cocoapods?

rad182 commented 8 years ago

@nlabhart i ended up adding the source files manually

nlabhart commented 8 years ago

Thanks @rad182 thats helpful.

nlabhart commented 8 years ago

Actually @rad182 is your project Swift, or Object-c?

rad182 commented 8 years ago

@nlabhart swift. i just added bridging header for obj-c files :(

hsousa commented 8 years ago

A swift version might be in the roadmap... :)

hsousa commented 8 years ago

Closing this thanks to @iVanPan's input. I'll re-open if anyone else can replicate the issue with Carthage >=0.9.4.