hsuanxyz / ion2-calendar

📅 A date picker components for ionic2 /ionic3 / ionic4
https://hsuanxyz.github.io/demo/ion2-calendar/
MIT License
555 stars 278 forks source link

fix: fix selected date style #233

Closed adamtahoun closed 5 years ago

adamtahoun commented 5 years ago

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Demos changes
[ ] Other... Please describe:

What is the current behavior?

Currently when using range selection on the calendar. If you chose the same start and end date then the date selected has a abnormal styling.

Here is an example of what is currently looks like: calendar-broke

What is the new behavior?

With this change the selected date is now styled as a circle as expected.

Here is an example of what is looks like with this change: calendar-fixed

Does this PR introduce a breaking change?

[ ] Yes
[x] No
ulesta commented 5 years ago

Looks good! Thanks for fixing this! 💯