search

hsvab / odbr

Pacote que disponibiliza dados de pesquisas OD do Brasil
https://hsvab.github.io/odbr/
GNU General Public License v3.0
14 stars 2 forks source link

Function read_dictionary() currently does not return dictionary data.frame #13

Closed rafapereirabr closed 11 months ago

rafapereirabr commented 11 months ago

https://github.com/hsvab/odbr/blob/67435807850917b1d958e9c5d728039baa862b42/R/read_dictionary.R#L30C3-L30C24

The function read_dictionary() currently returns the url address of the dictionary. The file still needs to be downloaded and read. Something along these lines:

# download dictionary
dic_file <- download_piggyback(filename_to_download) 

# read dictionary
dic <- data.table::fread(filename_to_download)

return(dic)
hsvab commented 11 months ago

Not all the files are up to date, but the function should be working properly now. Could you try again @rafapereirabr?

rafapereirabr commented 11 months ago

I just tested the function and it's working great! thanks !