Py2 compatibility: add Numenta, NumentaTM, htmjava detectors

htm-community / NAB

The Numenta Anomaly Benchmark

GNU Affero General Public License v3.0

3 stars 3 forks source link

Closed breznak closed 5 years ago

breznak commented 5 years ago

[x] allows to install (old) detectors that depend on python 2 to an automatic virtualenv
[x] re-adds Numenta, NumentaTM, htmjava detectors
[x] I think this has been running, probably made some errs in rebasing to this repo, as this is now failing
- fixed by adding custom run.py lost during merge

TODO for a separate task:

[ ] make py2 install scripts platform independent (currently assumes UNIX)
- install_py2_detectors.sh

This has also been submitted to numenta/NAB https://github.com/iandanforth/NAB/pull/9

breznak commented 5 years ago

Please review when you have time, most of the large file changes is just copied from the py2 branch of NAB.

ctrl-z-9000-times commented 5 years ago

Cool! If I may ask, how did you test this? What were the results?

breznak commented 5 years ago

If I may ask, how did you test this?

yes, locally. All combinations (py2,3) of detectors install and work seamlessly. That is the goal of this PR.

What were the results?

I don't quite understand. This is not (yet) our htm.core, "just" original numenta's Numenta & NumentaTM detectors using py2.

I do get similar, but slightly different results. But I do have the same behavior even with upstream numenta/NAB (due to random fluctuations) I guess the slight changes (with overall same score) should be ok?
our htm.core detector is queued and waiting for this to get merged ;)