search

html-next / ember-hammertime

TouchAction (aka "fastclick") Support for Ember Applications
MIT License
56 stars 23 forks source link

(bugfix) tagless components error part2 #25

Closed eriktrom closed 8 years ago

eriktrom commented 8 years ago

Mimic pre-glimmer2 behavior of attributeBindings

fixes #19

eriktrom commented 8 years ago

@runspired - this worked in 4 or so use cases where other hacks did not. For example, attribute bindings within ember-async-image now work upon deferred loading (as one example https://github.com/runspired/ember-async-image/blob/daf5e88ecc3aafcce9e32394f4848132628e07f0/addon/components/async-image.js#L26)

worth noting I did not mean to re-write the whole mixin - at all - I think there is an upstream bug in Ember TBH and I was about to give up but upon reading the source code saw a line that made me think I could hack around this by modifying the prototype of the mixin from within the constructor - and bam, all edge cases started working - I deleted the cruft but did not back out all the way and return the file back to what you are likely more familiar with - let me know if thats an issue and I will

eriktrom commented 8 years ago

CI: image

eriktrom commented 8 years ago

actually dont merge this - i think i can just take that magic line and paste it into master branch here after dinner - master has some good code i dont want to lose - just fyi

runspired commented 8 years ago

@eriktrom wasn't going to merge cause it was a big enough clobber I was going to need to work through it for a while :P a simpler PR is very welcome :)

eriktrom commented 8 years ago

yeah i know :) it was after too much hacking and not enough sleep late in the day haha