html-next / ember-hammertime

TouchAction (aka "fastclick") Support for Ember Applications
MIT License
56 stars 23 forks source link

Dont use Ember.K to check for typeof function check #27

Closed eriktrom closed 8 years ago

eriktrom commented 8 years ago

fixes issue whereby every {{some-component}} was being given the touch action style tag

K

eriktrom commented 8 years ago

And yes we badly need to fix up the tests - and the harness - and add a couple of tests for when the attr should NOT be applied b/c a copy paste + passing tests = lets PR - oh crap, it wasn't working right before the copy paste - or was it? dunno

seems like for tests we just need to get chrome to install - u wanna file an issue with any details in your head - i'll take a look (EDIT: for example i didn't know u could install chrome on travis, nor apt-get packages - link me)

runspired commented 8 years ago

An example of this test harness setup working I believe is flexi.

eriktrom commented 8 years ago

welp - upon looking through git it looks like that Ember.K was always being used oddly starting here - 00de65b38ecbffee8ddf7d1fccead15a923e78cd - which in git log shows up as you resolving a merge conflict (at least that is the commit message) - i cant find the original usage - from there is just was copy pasted

I guess the problem regarding using that check in general is that it just checks one function against another - their both separate objects unless u call them and get the return value and the maybe return a new function (in which case i guess u could the guids of the object they live on - maybe this is what u meant

for now i just used this.click && this.click.apply which seems faster at least than typeof

everything seems working upon use in my app - looks ready to merge

agree though on perf - perhaps glimmer2 can help here - regarding perf - the biggest concern is the dom nodes(well many extra attrs i should say) we create -- but another day...

runspired commented 8 years ago

I have a plan there too, but it has to happen upstream in hammertime first