Question: Is this a replacement for FastClick?

html-next / ember-hammertime

TouchAction (aka "fastclick") Support for Ember Applications

MIT License

56 stars 23 forks source link

Question: Is this a replacement for FastClick? #6

Closed alizahid closed 8 years ago

alizahid commented 8 years ago

If I have this library, can I skip FastClick? Or do I need that anyway? I'm building Ember apps for mobile.

runspired commented 8 years ago

Skip fastclick, this is a replacement.

alizahid commented 8 years ago

I'm seeing the 300ms delay on mobile if I package my app through Cordova. Any ideas?

runspired commented 8 years ago

@alizahid

Potential errors

did you also install FastClick
are you using wkWebView and iOS 9.3+ and an old version of ember-hammertime?
what is the viewport meta tag set to?
did you npm install instead of bower install, and are missing hammer-time?

alizahid commented 8 years ago

did you also install FastClick - no
are you using wkWebView and iOS 9.3+ and an old version of ember-hammertime? - no
what is the viewport meta tag set to? - user-scalable=no, initial-scale=1, maximum-scale=1, minimum-scale=1, width=device-width
did you npm install instead of bower install, and are missing hammer-time? - ember install ember-hammertime

runspired commented 8 years ago

@alizahid can you detail which platform you are on?

alizahid commented 8 years ago

Ember 2.4.5
Ember Data 2.5.2
jQuery 2.2.3
iOS 9.3.1 (13E238)
Mozilla/5.0 (iPhone; CPU iPhone OS 9_3_1 like Mac OS X) AppleWebKit/601.1.46 (KHTML, like Gecko) Mobile/13E238 (367551184)
iPhone 6S
Cordova 6.1.1
Cordova iOS 4.1.1

You can see the styles are applied. But it's not working.

I even tried to install ember-hammertime again, but no change.

PS: there's no delay if I run the app in Safari on the iPhone. Only when it's packaged through Cordova. Could be a conflict?

runspired commented 8 years ago

@arschmitz

arschmitz commented 8 years ago

So this seems like an iOS bug thats not properly applying the css. hammer-time is a noop on 9.3 currently and touch-action: manipulation is natively supported in iOS 9.3.

@runspired have you seen touch-action: manipulation working at all in cordova in 9.3? not sure i have tried it.

runspired commented 8 years ago

@arschmitz yes, I'm worried that hammer-time's no-op is doing a bad check, since this appears to be isolated to uiWebView on 9.3

runspired commented 8 years ago

@alizahid fwiw I know other teams are using this with cordova and it's working on 9.3 for them. There's definitely something strange here that you are still seeing a 300ms delay, and after looking at how hammer-time does the touch-action support check, I think it's increasingly likely there's something going on in your cordova config. It's also possible that you are making use of :hover classes on these buttons/links?

@arschmitz I don't think this should be no-op for uiWebView on 9.3.... https://github.com/hammerjs/hammer-time/blob/master/hammer-time.js#L17

alizahid commented 8 years ago

I have no :hover styles, and using the stock Cordova configuration.

If it's a 9.3 bug, do note that the delay isn't there in Safari browser, only in UIWebView.

Just tested it on Android 6, no delay.

arschmitz commented 8 years ago

@runspired is right i don't noop in the webview it does not support touch-action however not really sure what the issue is. I have not had any other reports of issues in cordova and i know @runspired and others are using it successfully.

gnazarkin commented 8 years ago

Having the same problem. @alizahid any solutions you've found?

alizahid commented 8 years ago

@gnazarkin No, I still haven't.