Closed luxzeitlos closed 7 years ago
I ran into the same error when I had an each
as the only thing in the vertical-collection
block. Given I was having the same error as using an if
, I figured it might be because there's a tagless component so I wrapped the each in a div
and things worked. Any ideas on how to fix it? Or where to look to patch it?
This is related to #24, it has to do with the way we are moving DOM around to avoid thrashing Glimmer. We may be able to avoid these issues if we remove the .virtual-component-renderer
div and just render the VCs directly to the main component element, but that could also cause more issues - we'll have to play around with it.
It may be a hard requirement to have a stable root element in place, similar to ember-wormhole
, until the Custom Components RFC lands. I'm hoping that will enable us to extend Glimmer in a better way than we are currently.
Should we treat this as a documentation issue then for now?
I'm going to try to solve it for beta 2 next week, but if that doesn't work then yes we should.
@pzuraq with the virtual bounds this should not be an issue. We may have implemented the bounds moving logic incorrectly.
Yeah, that's what I'm thinking. I think we need to go back to the original design you implemented, where the virtual bounds were used for the VC each
instead of a div container, that's what's tripping Glimmer up. I'll be able to take a look at it first thing next week.
@scottmessinger @luxferresum I should be getting beta.2
out this week or early next with this patch in! Let me know if the issue is fixed on your end, I think this should be solid
I can confirm that it's now working on master. For now this is a "works on my machine", but I will push it to testing as soon beta.2 is out.
I'm having the same error with 1.0.0-beta.13
while trying to change the collection of items while filtering them @pzuraq @runspired
Is vertical-collection
meant to work only with non-mutable collections?
This template:
with this data:
breaks with
I'm not sure if this should be supported, but it AFAIK worked in smoke-and-mirrors.