search

htw-imi-showtime / showtime-website

The official IMI showtime website
10 stars 105 forks source link

B5 Pam: New Picture, New Techstack, Personal Reflections, Future and more #403

Closed LVOswald closed 1 month ago

LVOswald commented 1 month ago

Opening a Pull Request to Update your Project

I've started a documentation on how we should use the forking workflow here:

https://github.com/htw-imi-showtime/showtime-website/blob/documentation/doc/forking-workflow/index.md (will not be merged to main due to file sizes)

Please follow these Steps & Guidelines for your Pull Request:

Before you Request a Review Check and Tick these Boxes:

[] make sure that the hugo site build works and check the result visually. [] merge your local branch with upstream/main (see update doc) [] Deploy the Site on your github pages by activating the "Deploy Page using GH-Actions" Workflow in "gh-pages-action.yml" [] make sure that your PR contains only files / file changes within your project subdirectory. [] make sure that all your file names consist only of lower case letters, numbers, or [-_.] - with only one . for the file extension [] delete all unnecessary files from your PR (including cat.jpg and kitty.jpg) [] check the image file sizes. All Images have to be as small as possible. See ./doc/disk_usage.md about this issues, there's a script: ./bin/images-smaller.sh

Note that if you fail to do so, I may simply reduce the file sizes brute force using the script above - WITHOUT CHECKING THE QUALITY

[] if everythings seems fine, request a review by bkleinen on github. (on the upper right)

Fill out this Information:

  1. Change the PR Title to: (e.g. B0 - update techstack.md) and describe your changes:

  2. URL of your Preview Site Containing the Changes: https://lvoswald.github.io/PAM-showtime-website/

  3. When did your Project Supervisor review your changes? (Date/Note or require review for PR): 30.7.2024

bkleinen commented 1 month ago

26 commits seit Juni??

LVOswald commented 1 month ago

Leider waren sehr viele Grammar fixes und so nötig. Ich mache sehr viele Commits.

Muss noch etwas verändert werden? Gibt es Probleme?

bkleinen commented 1 month ago

Bitte einfach mal den Status hier angucken: image

Darüber hinaus frage ich mich, warum der PR commits vom Juni enthält. Das weist darauf hin, dass Sie von einer alten version ausgehen.