hubmapconsortium / gateway

MIT License
0 stars 0 forks source link

NickAkhmetov/HMP-519 Update maintenance bundle to look up maintenance message from S3 #303

Closed NickAkhmetov closed 10 months ago

NickAkhmetov commented 10 months ago

This PR updates the maintenance page bundle to include the functionalities added in https://github.com/hubmapconsortium/portal-ui/pull/3364 - i.e. the maintenance page now fetches a .md file from the s3 bucket which contains the text to be displayed.

yuanzhou commented 10 months ago

@lchoy and @NickAkhmetov, this is a brilliant idea! Only a very minor issue I noticed today, maybe it has been like this since the beginning. The links at the footer are all external links, but only two has that external link icon. Would you mind updating them for the sake of consistency?

Screenshot 2024-01-05 at 9 20 08 AM
NickAkhmetov commented 10 months ago

@yuanzhou That's an interesting question! This is the same footer we have in the rest of the data portal application, minus the links to internal pages, so this does largely match the rest of the site.

With some of these links (project website, data sharing policy, overview) I can see why we don't have an external link icon, as these are technically still HuBMAP sites. However, GitHub should probably have an external link icon by this logic.

@tsliaw, do you recall what criteria we use to determine whether to use an external link icon or not?

NickAkhmetov commented 10 months ago

After confirming with Tiffany,

NickAkhmetov commented 10 months ago

@yuanzhou It should be all set now - I rebuilt the maintenance page from the branch where I have the footer links updated: https://github.com/hubmapconsortium/portal-ui/pull/3368

Updated maintenance footer: 294593317-a0f822bb-5f27-43e4-9f96-e6fa7bc044f2

yuanzhou commented 10 months ago

@NickAkhmetov thank for your attention to details!