search

hubot-archive / hubot-auth

Assign roles to users and restrict command access in other scripts
149 stars 54 forks source link

list all custom roles #27

Closed zGrav closed 8 years ago

zGrav commented 8 years ago

PR for my opened issue #26 .

If approved, will do a "delete custom roles" command if possible as well, just to keep everything tidy.

zGrav commented 8 years ago

Not seeing why tests have failed, anyone shine a light?

zGrav commented 8 years ago

there we go 👍 errors were due to outdated version.

patcon commented 8 years ago

Thanks @zGrav! But not sure I'm comfortable merging this yet. I'm admittedly not using this script right now, but something about this approach doesn't feel right...

could we instead display the roles present in "hasRole" in other scripts, without storing some list in the brain that may not reflect actual access-control roles that are available?

Would be really interested to hear feedback from others using hubot-auth before we consider merging this

patcon commented 8 years ago

It sounds like a new PR is in order, so I'm just going to close this out (obviously still open for discussion)

Def speak up if you feel otherwise