search

hubotio / generator-hubot

Hubot generator for Yeoman
MIT License
156 stars 83 forks source link

We're only running Hubot, so skip dev packages #35

Closed mal closed 9 years ago

mal commented 9 years ago

Shouldn't need devDependencies for this. Should make startup faster as there'll be a lot less packages to version check.

technicalpickles commented 9 years ago

I can appreciate wanting to make startup quicker, but this would mean that if you can't have development dependencies for use in development.

If running hubot in production is trying to install dev dependencies, I think that's a different bug.

michaelansel commented 9 years ago

@technicalpickles do you mean we should have different ways of launching the bot in dev vs prod? Requiring a manual npm install when developing seems reasonable (most packages always require a manual npm install)

technicalpickles commented 9 years ago

@michaelansel I think the main thing would be setting NODE_ENV=production in production. I did some research on it, and it seems that npm install respects that, and won't install development dependencies.

technicalpickles commented 9 years ago

Another data point re running in development vs production... we have a convention that projects should have a script/server for launching the server in production. I'd posit that probably that'd be the way to npm install in development, and that your production deploys should have a way to npm install at some point (heroku should do it automatically, capistrano can run it after update_code), etc.

mal commented 9 years ago

Closing this as it seems like there are better solutions.