Closed annakrystalli closed 9 months ago
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:
@annakrystalli Added myself as a reviewer just to say that this looks good from my perspective (and TIL about testthat snapshots)
Looks like you're still in WIP but tag me when you're ready for final 👀
Thank you! Will do!
🚀 Deployed on https://65c631bb4ff1a003dcdd0592--hubdevs-pr-previews.netlify.app
Hey @bsweger ! Added a few more bits and pieces in preparation for going round the houses and updating all packages to hubStyle
template. Ready for you review now!
I'm not really sure how to ignore files for codecov.
Re, how I tend to use this is I generally look for overall coverage rather than every line of code being covered as I find that level of checking often excessive and sometimes demanding tests for well tested external functions etc.
In any case, this package is definitely lacking tests because of the difficulty in testing some of the GitHub API behaviour for creating new repos (even usethis developers test some of the functionality manually). There are ways around it through mocking but I've parked that for now because, given this is not a user facing package, it's not that high priority.
This PR:
use_hubdev_pkgdown()
stagepkgdown
action if present.Both these latter features will make migration to
hubStyle
theme smoother.I've also now officially completed setup of hubStyle docs for this package, primarily by setting up Netlify previews with was the main outstanding task (#4 )