search

hudl / fargo

Golang client for Netflix Eureka
MIT License
133 stars 53 forks source link

add InstanceId in Instance struct #43

Closed qizha closed 6 years ago

qizha commented 8 years ago

missing the instanceId which lead the service registered without instanceId and can not be retrieved by the instanceId later.

seh commented 8 years ago

See #44 for related changes that allow one to tunnel an instance ID through to data center types that implement com.netflix.appinfo.UniqueIdentifier via metadata inspection, as well as get such an instance ID back out via a bound Instance.UniqueID field.

damtur commented 8 years ago

@qizha Are you using some other provider then Amazon? We are using InstanceId from DataCenterInfo can you use that one as well?

qizha commented 8 years ago

thanks for the response. I am not using Amazon right now. Actually, I am going to use Kubernetes with Eureka. I found the problem when I tried Eureka registry plugin with go-micro(https://github.com/micro/go-plugins/blob/master/registry/eureka/) running in my laptop.

damtur commented 6 years ago

Similar change has been merged with https://github.com/hudl/fargo/pull/67 Closing this as Resolved.