search

huggingface / huggingface_sb3

Additional code for Stable-baselines3 to load and upload models from the Hub.
77 stars 23 forks source link

Release v.2.3 breaks backwards compatibility #37

Closed ernestum closed 1 year ago

ernestum commented 1 year ago

The switch to gymnasium is not backwards compatible, therefore release v2.3 should have been v3.0.

SemVer recommends doing a v2.3.1 release with the state of v2.2.5 and then doing a v3.0 release with the state of v2.3.0

ernestum commented 1 year ago

Workaround in the meantime: pin huggingface_sb3 version with huggingface_sb3==2.2.5

simoninithomas commented 1 year ago

Hey there 👋 should be ✅. I agree it would be cleaner this way. Thanks for your help 🤗

ernestum commented 1 year ago

Awesome thank!