search

huggingface / llm-vscode

LLM powered development for VSCode
Apache License 2.0
1.24k stars 133 forks source link

runCompletion.ts: Respect isFillMode setting #52

Closed matthiasgeihs closed 1 year ago

matthiasgeihs commented 1 year ago

Fixes #51

matthiasgeihs commented 1 year ago

Is this repository still maintained? Should be an easy approve to an obvious bug fix. (This will re-enable usage of non-FIM models.)

Maybe @mishig25 would be the right person to look at this?

McPatate commented 1 year ago

Hello @matthiasgeihs, we're currently in the works of massively refactoring the extension.

I think this should be fixed, but please let us know if you still experience this issue after 0.1.0 is released.

McPatate commented 1 year ago

0.1.0 is released, please let me know if everything works as expected now. I'll close the issue if I don't see a reply in the coming days assuming the problem is gone. Feel free to open another PR in case I close too soon.

matthiasgeihs commented 1 year ago

@McPatate Great to see that a new release is out.

Feel free to close this one. I'll reopen if problems persist.

McPatate commented 1 year ago

Closing, thanks for taking a shot at this anyways!