[Bug] `TypeError: Config.__init__() [...]` from `examples/config_tiny_llama.py`

[saforem2]

Fixed by #33

For reference:

I was getting TypeError: Config.init() missing 1 required positional argument: profiler' when trying to run examples/config_tiny_llama.py.

Explicitly:

$ python3 examples/config_tiny_llama.py
Model has 16p4K parameters
Traceback (most recent call last):
  File "/lus/grand/projects/datascience/foremans/locations/polaris/projects/saforem2/nanotron/examples/config_tiny_llama.py", line 90, in <module>
    config = Config(
TypeError: Config.__init__() missing 1 required positional argument: 'profiler'
[1]    30778 exit 1     python3 examples/config_tiny_llama.py
2.78s user 5.53s system 231% cpu 3.590s total

the issue is coming from this line in the Config object in src/nanotron/config/config.py:

https://github.com/huggingface/nanotron/blob/main/src/nanotron/config/config.py#L334

Setting the Optional[ProfilerArgs] = None by default (as shown below) fixes this:

@dataclass
class Config:
    # [...]
    profiler: Optional[ProfilerArgs] = None

[thomwolf]

thanks for the issue, Setting the Optional[ProfilerArgs] = None by default prevent subclassing the Config in other training scripts though, which is usefull to add features without making nanotron too big.

So best will probably be to add profiler = None in examples/config_tiny_llama.py if you can open a PR for this. Cc @NouamaneTazi

[saforem2]

ahh okay, yeah that makes sense. that was actually what I did here initially before reverting it.

@thomwolf, @NouamaneTazi this should be resolved following these two commits:

• 7ed240ba: Removes Optional[ProfilerArgs] = None
• 8d52b084: Sets profiler=None in Config(...)

[NouamaneTazi]

Thanks for the issue & fix 🤗