Open llCurious opened 1 month ago
The underlying Trainer wraps the model. There should be an arg to enable DP (will try and find it in a moment)
It might be useful if the error message could provide the forward method's signature so users would know what columns need to exist in the dataset object.
Thanks for the feedback @wbuchanan ! Would you like to submit a PR to add this information ?
@SunMarc if I knew where to find the information programmatically I could try, but it isn't clear where the information would be located.
Right here : https://github.com/huggingface/transformers/blob/e259d6d1e0d2acfa3c2f84b11c9bfa97e64b984d/src/transformers/trainer.py#L840. You can just add in the error msg the signature_columns
variable !
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.
Please note that issues that do not follow the contributing guidelines are likely to be ignored.
System Info
transformers
version: 4.44.0Who can help?
@muellerzr @SunMarc @ArthurZucker
Information
Tasks
examples
folder (such as GLUE/SQuAD, ...)Reproduction
Expected behavior
Expected: No ValueError: No columns in the dataset match the model's forward method signature. is raised.
It seems to me the error occurs since DataParallel wraps the model.
However, I wonder the preprocessing logic in SFTTrainer.