hughperkins / tf-coriander

OpenCL 1.2 implementation for Tensorflow
Apache License 2.0
791 stars 90 forks source link

unable to build from source #22

Closed guoyejun closed 7 years ago

guoyejun commented 7 years ago

I follow the build instructions step by step on my ubuntu16.04 x64 system, but met issue when run image

The followings are the log at end. ... INFO: From Compiling tensorflow/core/lib/io/inputbuffer.cc: tensorflow/core/lib/io/inputbuffer.cc: In member function 'tensorflow::Status tensorflow::io::InputBuffer::ReadNBytes(tensorflow::int64, std::__cxx11::string*)': tensorflow/core/lib/io/inputbuffer.cc:81:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (bytes_read < bytes_to_read) result->resize(bytes_read); ^ At global scope: cc1plus: warning: unrecognized command line option '-Wno-unused-local-typedef' cc1plus: warning: unrecognized command line option '-Wno-c++11-narrowing' INFO: From Compiling tensorflow/core/lib/io/snappy/snappy_outputbuffer.cc: tensorflow/core/lib/io/snappy/snappy_outputbuffer.cc: In member function 'tensorflow::Status tensorflow::io::SnappyOutputBuffer::Write(tensorflow::StringPiece)': tensorflow/core/lib/io/snappy/snappy_outputbuffer.cc:42:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (bytes_to_write <= AvailableInputSpace()) { ^ tensorflow/core/lib/io/snappy/snappy_outputbuffer.cc:53:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (bytes_to_write <= AvailableInputSpace()) { ^ tensorflow/core/lib/io/snappy/snappy_outputbuffer.cc: In member function 'void tensorflow::io::SnappyOutputBuffer::AddToInputBuffer(tensorflow::StringPiece)': tensorflow/core/lib/io/snappy/snappy_outputbuffer.cc:110:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (bytes_to_write > free_tail_bytes) { ^ At global scope: cc1plus: warning: unrecognized command line option '-Wno-unused-local-typedef' cc1plus: warning: unrecognized command line option '-Wno-c++11-narrowing' ERROR: /work/ml/tensorflow-cl/tensorflow/core/BUILD:956:1: undeclared inclusion(s) in rule '//tensorflow/core:lib_internal': this rule is missing dependency declarations for the following files included by 'tensorflow/core/platform/profile_utils/cpu_utils.cc': '/work/ml/tensorflow-cl/tensorflow/core/platform/profile_utils/android_armv7a_cpu_utils_helper.h'. Target //tensorflow/tools/pip_package:build_pip_package failed to build INFO: Elapsed time: 110.980s, Critical Path: 102.10s ERROR: Build failed. Not running target.

Actually, i do not understand why android_armv7a is involved, my system is ubunut 16.04 with Intel skylake.

Anything i can have a try? thanks.

guoyejun commented 7 years ago

with the same system, i built native tensorflow (ca29fa3cc16663a8dddf5968b5600c60e2dc71a8) from source and it works with either python3 or python2 (using virtualenv).

looks that i have to look into the build to see what happens ...

guoyejun commented 7 years ago

got it, the issue is introduced with 6cdbe2a0857cd3801a36eb70a165e841869c6f79

to follow your idea, the fix could be comment the #include in file cpu_utils.cc, i'll send out the patch