search

huguesrichard / Allopipe

AlloPipe is a computational method to assess the alloreactivity expected from a donor/recipient transplantation pair
MIT License
0 stars 0 forks source link

AMS/af-AMS multiprocess done #12

Open PierreLaville opened 4 months ago

PierreLaville commented 4 months ago

When running multiprocess_ams.py and facing an error (here was simply forgetting to activate the Conda environment) and didn't output anything, still prints the success message:

Done comparing the couple

This either needs a more robust way to check wether the run is successful or not, or should not print this.

PierreLaville commented 4 months ago

Same goes for multiprocess_aams.py which has a very similar function (launch_aams_pipeline) which may cause a similar error.

PierreLaville commented 4 months ago

This is also the case for the "y/N" question mentioned in #7, even if "no" is selected, still prints "done".

huguesrichard commented 1 month ago

Ok, that means we need to implement a system with lock files or result files that are tested for existence after it is run.