search

hulkrelax / hltb-for-deck

A plugin to show you game lengths according to How Long To Beat
MIT License
48 stars 15 forks source link

Not working (fresh install) #37

Open solomani opened 1 month ago

solomani commented 1 month ago

Hi all, this plugin is not working. Initially, I thought it may be a clash, but even if it is the only plugin, it doesn't work. I have the latest version of SteamOS, using stable options as well as deckyloader etc. Wondering what I can check to troubleshoot the issue?

HirschBerge commented 1 month ago

If you were to go through the other issues, or look at the releases, you'd see that this isn't maintained and that you should put issues on here: https://github.com/SDH-Stewardship/hltb-for-deck

solomani commented 1 month ago

Thanks, but I cant post issues on that version, hence I posted here.

HirschBerge commented 1 month ago

@safijari open up issues if you're serious about maintaining this

felixhirschfeld commented 1 month ago

It's solved here, we just need to wait for release

https://github.com/SDH-Stewardship/hltb-for-deck/pull/4

safijari commented 1 month ago

@safijari open up issues if you're serious about maintaining this

*please

I've opened issues now (https://github.com/SDH-Stewardship/hltb-for-deck/issues). That said my intention is to put in the bare minimum to keep the plugin alive for the community. If someone wants to develop new features I'd be happy to add them but I won't be doing this myself.

The issue mentioned here is fixed in testing. Please test and give feedback (if any) on the SDH PR https://github.com/SteamDeckHomebrew/decky-plugin-database/pull/661

The flickering issue is being worked on right now by MoonDeck's dev

solomani commented 1 month ago

Confirmed it is now working after the last update, thank you.

solomani commented 1 month ago

As a follow-up, can we add a discussion section as well? I have some questions but they are not bugs/issues. Thanks.

solomani commented 1 month ago

FYI this problem has returned. Not working again but not sure why.

safijari commented 1 month ago

HLTB changed the API in a way such that it's not clear how to use it anymore. I'll have to look more into it

solomani commented 1 month ago

Thank you.

felixhirschfeld commented 1 month ago

They added something to the url which maybe an access token that is likely to change. https://howlongtobeat.com/api/search/4b4cbe570602c88660f7df8ea0cb6b6e

kangyili commented 1 month ago

I've added a tiny PR to fix it temporarily https://github.com/SDH-Stewardship/hltb-for-deck/pull/7

Rhylthus commented 1 month ago

I've added a tiny PR to fix it temporarily SDH-Stewardship#7

Could you please provide an installable zip? Thanks

safijari commented 1 month ago

I've merged and can get it released in a bit but were in some unfortunate territory here. HLTB does not have an official public API so we've just been coasting off of using their internal API and not getting noticed.

It's clear they've started implementing mitigations against that. I would expect this hash to get rotated often. In theory the plug-in could evolve to cache data locally and get the hash from a remote place (e.g. git repo) so changes to hash can be deployed quickly (the local cache would ensure that data remains available in the transition period).

This is getting into active development territory though and my original intention was to maintain. If someone wants to take over development please let me know and I can add you to the SDH Stewardship repo and let the SDH folks know there's a new maintainer.

On Wed, Aug 7, 2024, 12:24 PM Rhylthus @.***> wrote:

I've added a tiny PR to fix it temporarily SDH-Stewardship#7 https://github.com/SDH-Stewardship/hltb-for-deck/pull/7

Could you please provide an installable zip? Thanks

— Reply to this email directly, view it on GitHub https://github.com/hulkrelax/hltb-for-deck/issues/37#issuecomment-2273855214, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHTRJCD3F2X6UH4R6EJR3LZQJC4ZAVCNFSM6AAAAABLSMVSXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZTHA2TKMRRGQ . You are receiving this because you were mentioned.Message ID: @.***>

HirschBerge commented 1 month ago

Would it be possible to have a box in the ui for the plugin where the user can fill In the hash and maybe keep a stickied thread/discussion where it's shared? Not very elegant and if they implement other mitigations it might still break, but it's something to think about

biokillos commented 3 weeks ago

I've opened PR that fetches the latest API key from the website inspired by the python hltb package solution - https://github.com/SDH-Stewardship/hltb-for-deck/pull/10. If someone could test it out it would be awesome. It's one of my favorite deck plugins, it would be nice to keep it working.

Would it be possible to have a box in the ui for the plugin where the user can fill In the hash and maybe keep a stickied thread/discussion where it's shared?

I think that would be too much work for a user. The key is changed at least weekly if not more often. Even myself, I wouldn't bother with manual entry if that's so often.

Rhylthus commented 2 weeks ago

I've opened PR that fetches the latest API key from the website inspired by the python hltb package solution - SDH-Stewardship#10. If someone could test it out it would be awesome. It's one of my favorite deck plugins, it would be nice to keep it working.

Would it be possible to have a box in the ui for the plugin where the user can fill In the hash and maybe keep a stickied thread/discussion where it's shared?

I think that would be too much work for a user. The key is changed at least weekly if not more often. Even myself, I wouldn't bother with manual entry if that's so often.

Is it possible to have an installable zip please ? Thanks.

safijari commented 2 weeks ago

I've opened PR that fetches the latest API key from the website inspired by the python hltb package solution - SDH-Stewardship#10. If someone could test it out it would be awesome. It's one of my favorite deck plugins, it would be nice to keep it working.

Would it be possible to have a box in the ui for the plugin where the user can fill In the hash and maybe keep a stickied thread/discussion where it's shared?

I think that would be too much work for a user. The key is changed at least weekly if not more often. Even myself, I wouldn't bother with manual entry if that's so often.

Is it possible to have an installable zip please ? Thanks.

If you change to pre-release Decky and then set your store to Testing you'll find a version of HLTB that has both the API issue and the flickering issue fixed

Rhylthus commented 2 weeks ago

I've opened PR that fetches the latest API key from the website inspired by the python hltb package solution - SDH-Stewardship#10. If someone could test it out it would be awesome. It's one of my favorite deck plugins, it would be nice to keep it working.

Would it be possible to have a box in the ui for the plugin where the user can fill In the hash and maybe keep a stickied thread/discussion where it's shared?

I think that would be too much work for a user. The key is changed at least weekly if not more often. Even myself, I wouldn't bother with manual entry if that's so often.

Is it possible to have an installable zip please ? Thanks.

If you change to pre-release Decky and then set your store to Testing you'll find a version of HLTB that has both the API issue and the flickering issue fixed

Perfect thanks it works very well

solomani commented 2 weeks ago

Dumb question: how can I test this (as a normal user) - change emuDecky to "pre-release" updates? Not seeing a specific option for the HLTB plugin to activate beta builds. Thanks.

biokillos commented 2 weeks ago

@solomani in Decky Settings - General select update channel as pre-release and store channel as testing. The former is needed because newer version of HLTB plugin relies on Decky new v3 API. The latter is needed because the fixed version of the plugin still in the testing stage.

solomani commented 2 weeks ago

Perfect. I confirmed it's working. Let me know if you need more testing, happy to help.

neybrus commented 3 days ago

The plugin version is 1.4.6, the latest firmware is on the steam deck and still does not work.It's just terrible, it hasn't been working for more than a month, it's just terrible

markh110 commented 3 days ago

The plugin version is 1.4.6, the latest firmware is on the steam deck and still does not work.It's just terrible, it hasn't been working for more than a month, it's just terrible

@safijari posted this in another thread and it seems to have fixed things for me.

safijari commented 3 days ago

The plugin version is 1.4.6, the latest firmware is on the steam deck and still does not work.It's just terrible, it hasn't been working for more than a month, it's just terrible

How are you installing 1.4.6? Did you install from the testing store? 1.4.6 is not out yet and is currently submitted for testing (see https://github.com/SteamDeckHomebrew/decky-plugin-database/pull/687). I've tested it myself on stable and preview SteamOS + Decky and I've also gotten other reports that it works.

Can you please give more information about your system?