search

humanmade / protected-embeds

A drop-in replacement for WordPress.com protected embeds
11 stars 4 forks source link

Add shortcode UI for protected embeds #6

Closed goldenapples closed 8 years ago

goldenapples commented 8 years ago

Adds a basic UI for editing height, width, and other attributes. Includes some functionality for updating the embed code itself.

goldenapples commented 8 years ago

@joehoyle We've added this locally to provide a little bit of management tools for these embeds. Feel free to merge it on your end if you think it'd be useful.

joehoyle commented 8 years ago

Looks like this inadvertently reverts the addition of the object-cache stuff, I'll fix up!

goldenapples commented 8 years ago

I was wondering about that... I didn't have that commit locally, and it didn't look like it was working since I didn't see any wp_cache_set line in there. How does the row get added to the cache in the first place?

joehoyle commented 8 years ago

Oh good point :P possible oversight!

joehoyle commented 8 years ago

Closed in #7