humhub / humhub-prosemirror

Other
17 stars 8 forks source link

prosemirror-dev-tools/toolkit not working #72

Open schlagmichdoch opened 2 years ago

schlagmichdoch commented 2 years ago

I tried to implement prosemirror-dev-tools / prosemirror-dev-toolkit in order to make debugging and testing the prosemirror editor much more efficient. I was able to doge one error message by editing the Gruntfile but was left with another


  1. Install via npm
  2. Change humhub-prosemirror/Gruntfile.js the following line:
    rollupPluginBuble(),

    with these

    rollupPluginBuble({
    objectAssign: "Object.assign",
    transforms: {
        modules: false,
        dangerousForOf: true,
    },
    }),
  3. Wrap EditorView instance in applyDevTools method: from repository ReadMe:
import applyDevTools from "prosemirror-dev-tools";

const view = new EditorView /*...*/();

applyDevTools(view);

Done that in humhub-prosemirror/src/editor/index.js

import { applyDevTools } from 'prosemirror-dev-toolkit'
applyDevTools(this.view);
  1. run grunt rollup

Somehow afterwords the editor is not loaded properly and I get the following error messages: grafik

Interestingly the error also occurs without applyDevTools(this.view); inserted. The import itself is enough.

Any idea how to make it work?

schlagmichdoch commented 2 years ago

See branch for commited changes: https://github.com/schlagmichdoch/humhub-prosemirror/tree/add_prosemirror_dev_tools

ocavue commented 2 years ago

This should be fixed in the latest version of prosemirror-dev-toolkit

schlagmichdoch commented 1 year ago

If I do this:

import {applyDevTools} from "prosemirror-dev-tools";

const view = new EditorView /*...*/();

applyDevTools(this.view);

the original error messages are resolved now.

Apparently, the toolkit still is not working and throws the following error on the web console:

Uncaught TypeError: HTMLElement constructor: 'new' is required
    ProseMirrorDevToolkit http://127.0.0.1/assets/609e776a/humhub-editor.js?v=1684786792:16515

Screenshot 2023-05-22 222113

Luckily, since 6.1.2023 there is now a Chrome Extension available for prosemirror-dev-toolkit that does work with humhub. I'll keep this issue open though as it should also work when bundling via grunt