search

hungio / route-me

Automatically exported from code.google.com/p/route-me
0 stars 0 forks source link

RMPath enhancement code #29

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
I saw that RMPath had an unused BOOL instance variable named
scaleLineWidth.  I implemented a property that sets this value and wrote
code to draw the line appropriately based on this property.  When
scaleLineWidth is NO, lineWidth is in units of screen pixels.

I am attaching both source files and a patch.

Original issue reported on code.google.com by foo...@gmail.com on 5 Jan 2009 at 4:06

Attachments:

GoogleCodeExporter commented 8 years ago 
Here's an improved patch to replace the old one.  I made it faster and fixed a 
bug.

RMPath doesn't display paths wider or taller than about 2000 pixels.  This patch
fixes that by clipping the path's bounds to the screen bounds.  This patch also
includes a more elegant implementation of the scaleLineWidth property.

Original comment by foo...@gmail.com on 8 Jan 2009 at 9:25

Attachments:

GoogleCodeExporter commented 8 years ago 
P.S. that patch above also releases "points" in dealloc, fixing a memory leak.

Original comment by foo...@gmail.com on 8 Jan 2009 at 9:27

GoogleCodeExporter commented 8 years ago 
I'm using this patch and it works very well. It should be checked into the repo.

Original comment by scott.a....@gmail.com on 1 Mar 2009 at 5:26

GoogleCodeExporter commented 8 years ago 
Jan 08 version of patch incorporated in r209. Please test.

Original comment by halmuel...@gmail.com on 2 Mar 2009 at 3:51

GoogleCodeExporter commented 8 years ago 
Oops, Comment 4 is wrong; that was actually done in r211. But this patch 
introduced a crashing bug in a client 
app. I've reversed r211. Will, can you try this in a branch?

Original comment by halmuel...@gmail.com on 2 Mar 2009 at 8:19

GoogleCodeExporter commented 8 years ago 
Is these issues solved by r569 ? 
It look like very similar to this.

Original comment by vladimir...@gmail.com on 7 Aug 2009 at 10:45

GoogleCodeExporter commented 8 years ago 
Seems ok for me

Original comment by vladimir...@gmail.com on 22 Aug 2009 at 11:10

GoogleCodeExporter commented 8 years ago 
Over here it is still not working. I'd like to have some polygon overlays over 
my map, but it still runs into this error, even with the patch applied...

Original comment by schmalsp...@gmail.com on 24 Sep 2014 at 3:01