huynhsontung / Screenbox

LibVLC-based media player for the Universal Windows Platform
GNU General Public License v3.0
1.11k stars 44 forks source link

“Auto resize” feature may need improvement #414

Open Kirinni opened 3 months ago

Kirinni commented 3 months ago

Is your feature request related to a problem? Please describe.

I have some videos with very different resolutions. This causes the window to become either too large or too small when playing different videos after enabling the "Auto-resize" function. Although this gives me a better experience while watching videos, it requires me to manually adjust the window size after finishing playing a video in order to browse and select files.

Describe the solution you'd like

Record the size when in the common window. When playing a video, it automatically adjusts to the size of the video. When exiting the video, it restores the previously recorded size of the common window.

Describe alternatives you've considered

N/A

Additional context

Wishing screenbox can become better!

huynhsontung commented 3 months ago

Interesting approach! I agree that the auto-resize feature breaks the browsing experience a bit. Record the window size before the player expands and restoring the size when it collapses seems like a good compromise. The window still moves around when expanding and collapsing the player but at least the window size is maintained.

I'm wondering if using multiple windows can help in this case. The main window is for browsing and the secondary window is the player. Each window can be resized independently.

Kirinni commented 3 months ago

Interesting approach! I agree that the auto-resize feature breaks the browsing experience a bit. Record the window size before the player expands and restoring the size when it collapses seems like a good compromise. The window still moves around when expanding and collapsing the player but at least the window size is maintained.

I'm wondering if using multiple windows can help in this case. The main window is for browsing and the secondary window is the player. Each window can be resized independently.

At the beginning, I tried opening multiple windows. But I found that opening a video in the app wouldn't create another window. Only opening a video outside the app would lead to a new window, and I thought this was an intentional design. Just now, I made another try to enable the multi-window function. But when I returned to the settings interface after exiting it, the multi-window function turned back to the disabled state. It seems that I can't enable the multi-window function. I don't know what caused this situation.

huynhsontung commented 3 months ago

At the beginning, I tried opening multiple windows. But I found that opening a video in the app wouldn't create another window. Only opening a video outside the app would lead to a new window, and I thought this was an intentional design. Just now, I made another try to enable the multi-window function. But when I returned to the settings interface after exiting it, the multi-window function turned back to the disabled state. It seems that I can't enable the multi-window function. I don't know what caused this situation.

This is intended. The multiple instances option allows the system to launch a new app instance every time an activation is received, like opening a file from file explorer. Each app instance is not aware of the others. The settings toggle is a visual bug that will be fixed in the next update.

The multiple app windows I suggested is different. One app instance will manage multiple windows. This can allow additional capabilities like playing multiple media files from the same app instance, separating the browsing experience from the playback experience.

Kirinni commented 3 months ago

At the beginning, I tried opening multiple windows. But I found that opening a video in the app wouldn't create another window. Only opening a video outside the app would lead to a new window, and I thought this was an intentional design. Just now, I made another try to enable the multi-window function. But when I returned to the settings interface after exiting it, the multi-window function turned back to the disabled state. It seems that I can't enable the multi-window function. I don't know what caused this situation.

This is intended. The multiple instances option allows the system to launch a new app instance every time an activation is received, like opening a file from file explorer. Each app instance is not aware of the others. The settings toggle is a visual bug that will be fixed in the next update.

The multiple app windows I suggested is different. One app instance will manage multiple windows. This can allow additional capabilities like playing multiple media files from the same app instance, separating the browsing experience from the playback experience.

Thank you for your explanation. Now I understand.