huynhsontung / Screenbox

LibVLC-based media player for the Universal Windows Platform
GNU General Public License v3.0
1.11k stars 44 forks source link

Unintended UI flipping in right-to-left languages #429

Closed Y-PLONI closed 1 month ago

Y-PLONI commented 3 months ago

The image is displayed upside down, here is a screenshot in Windows Media Player image And here is a picture from Screenbox image As I wrote here: https://github.com/huynhsontung/Screenbox/issues/418#issuecomment-2309680883 The problems are that the application is configured in Windows in Hebrew mode and the operating system creates RTL for everything possible, including what is not needed... In my opinion, if possible, you should set the application as English, and only the text in it will be in Hebrew. If not possible, write to me and I will try to investigate the issue!

I use Windows 11, the latest version of the app released in the store.

huynhsontung commented 3 months ago

In the right-to-left language, are the window control buttons (minimize, maximize, close) on the left or the right of the window? There shouldn't be any navigation issue right?

ApplicationFrameHost_pb11w8588E

I did not expect WebView and SwapChainPanel to get flipped by RTL as well...

ApplicationFrameHost_FNdFmfKiCt

Screenshot 2024-08-26 022505

Fortunately, the solution is straightforward. I can force certain elements to not flip. Just as I can apply RTL even in English.

huynhsontung commented 3 months ago

Forcing WebView and VideoView to always flow LTR.

https://github.com/user-attachments/assets/f9dd334f-9f8b-4282-b429-2238e43b6818

@Y-PLONI Are there more UI elements or layouts that you think look off in Hebrew? Do the sliders and buttons behave correctly, and are they in the expected spots?

Y-PLONI commented 3 months ago

image image

Y-PLONI commented 3 months ago

Can you force normal view in both windows store and file explorer? Right now the situation is that things are changing there... here: image I assume you don't know Hebrew, so I'll just explain that the word Screenbox should have been at the beginning. Also note the position of the "." I was thinking of just changing everything in the translation... I mean, pushing the words so that they are in the correct position after Windows flips them... but if you have the ability to force, everything will be easier.

Y-PLONI commented 3 months ago

I was thinking of just changing everything in the translation...

Actually, that's what I did in the ManifestResources.resw file...

United600 commented 3 months ago

image image

I see we don't flip the icons, we should for most of them right?

Also we have to take into consideration the backslash on some of them. Like this:

Shuffle icon and it's mirrored counterpart

Y-PLONI commented 3 months ago

I see we don't flip the icons, we should for most of them right?

Also we have to take into consideration the backslash on some of them. Like this

I didn't understand what you meant. Can you explain more?

United600 commented 3 months ago

I didn't understand what you meant. Can you explain more?

Forgive my limited knowledge on this area, but I recall that some icons need to be flipped (e.g. the volume glyph, etc.) and after reviewing some documentation it seems to confirm that (except for those indicating directionality and right handedness).

huynhsontung commented 3 months ago

@Y-PLONI Can you take a look at #434 to see if that looks right to you?

Y-PLONI commented 3 months ago

@huynhsontung Looks great! Of course, until you see it in the software itself - you can't know clearly...

Y-PLONI commented 3 months ago

@huynhsontung Is there a release with the fix, or not? I didn't see any update in Windows Store.

huynhsontung commented 3 months ago

@Y-PLONI Yes, there will be a new release. Store publishing takes from a few hours to a few days. It's going to be available for download in the preview channel first, then in the main public channel later. I will also fix the store listing when it goes into the public channel.

Y-PLONI commented 3 months ago

How do you subscribe to the preview channel?

huynhsontung commented 3 months ago

@Y-PLONI I must add your Store account on my end using your Store email. You can send me an email at tung75605@live.com

Y-PLONI commented 3 months ago

I suggest you put in the settings "subscribe to the preview channel". It could be MAILTO.

Y-PLONI commented 3 months ago

@huynhsontung Everything is great, just a little something... image

Y-PLONI commented 2 months ago

@huynhsontung Could you please add RTL here? thanks! I have already installed the app on several computers... everyone loves it!!! image

Y-PLONI commented 2 months ago

By the way, I couldn't find where to translate the titles media, music, file

huynhsontung commented 2 months ago

@Y-PLONI You are right, the header texts for Media, Music, File are not properly localized. It will be fixed in the next patch.

I also just noticed that the title bar offset issue affects the app title and the player title bar, which is quite serious. In LTR, that space is reserved for the window controls. I'm surprised that it doesn't get flipped properly, considering if I force-enable RTL in English, the issue does not appear.

image image

Y-PLONI commented 2 months ago

@huynhsontung True, but it doesn't matter. The window controls just move to another place. Are there any other controls that are disappearing? I would love to see a screenshot of the software, as it looks on you.

huynhsontung commented 2 months ago

@Y-PLONI The above PR should fix the title bar padding issue and properties dialog RTL issue.

Y-PLONI commented 1 month ago

@huynhsontung why is it in english Where should I translate it? image Thank you very much!!!

huynhsontung commented 1 month ago

@Y-PLONI These errors are emitted from VLC and shown as-is. We don't map them to a localized string so translation is impossible.

yarons commented 1 month ago

@huynhsontung It's a good call but there's an alternative solution: adding a human readable translatable explanation to the original error message, this way the user can still search for the original message and find solutions on the internet while understanding the error in its own language. (Thanks @Y-PLONI)

Y-PLONI commented 1 month ago

@huynhsontung The top image is correct, the bottom is reversed. It was fine before. Something went wrong with the update. Also in the song playback window the image is reversed. image

image

huynhsontung commented 3 weeks ago

Version 0.14.1 with a fix for image flipping has been published. Please open a new issue and link to this one if there are other right-to-left issues.

Y-PLONI commented 3 weeks ago

image Great!!!