search

hwchase17 / langchain-hub

3.25k stars 263 forks source link

Fix various "bad" prompt-templates that potentially lead to odd results (qa-with-sources, qa) #34

Open Ajackster opened 1 year ago

Ajackster commented 1 year ago

I was loading qa-with-sources prompt templates from LangChainHub when I noticed I was getting odd answers. I tracked it down and it looks like some prompt templates were added in incorrectly and included an entire answer rather than just the template.

This PR replaces the corrupted prompt templates with what seemed like the proper template.

Support in testing or letting me know the easiest way to test this would be appreciated. From my brief overview of how prompt template loading works - I assume this should fix some issues but I have not actually tested it.

Issues reported in the langchain repository that could potentially be related: Hallucinating Question about Michael Jackson #2510 RuntimeError: Failed to tokenize (LlamaCpp and QAWithSourcesChain) #2645 Issue with VectorDBQAWithSourcesChain and chain_type="stuff" #1326

LuciferUchiha commented 1 year ago

@hwchase17 Is there a reason why this hasn't been merged yet?

moarshy commented 1 year ago

We just noticed we are getting the Micheal Jackson hallucination with LangChain version 0.0.129. Was wondering if this would fix and when this will be merged.