Stop annoying Russian botspam from oscar w/out blocking other protocols

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Use ICQ
2. Russian ICQ bot spams you with auth requests
3. You block all jabber, Yahoo, Gadu-Gadu and IRC users from getting on your 
buddy list.

I just wanted to submit a quick patch to block ONLY the "oscar" protocol from 
requesting authorization, since that's the only place where this annoying 
Russian spambot keeps sending me requests from random ICQ numbers.

A more permanent fix might be to have an option to block the spammer instead of 
only allowing me to type my polite explanation why I don't want Russianbot5534 
on my roster. I'm not sure you can modify that "are you sure you don't?" dialog 
though, without getting into pidgin's internals. Another idea might be a list 
of individual protocols (or individual servers within jabber) who can or can't 
send authorization requests depending on which one is being a source for 
botspam. Another idea might be to suppress the request prompt and build up a 
queue of requests, for the user to peruse at their leisure without having to 
click "no" on every request from every spammer ever. If everyone used digital 
signing instead of server password authentication this'd all be a lot simpler 
of course.

Original issue reported on code.google.com by goo...@synx.dyndns.org on 6 Jul 2010 at 7:43

Attachments:

• block-oscar.patch

[GoogleCodeExporter]

Thanks for the patch, I'll include it in the next release.

As for the dialogs: no, I can't really change those. Issue #2 already contains 
such a problem and hasn't been resolved by the pidgin people yet.

I like the request-queue idea, but IIRC a plugin can't tell pidgin to postpone 
a request - I'll have a look at it, though. Might be worth suggesting to the 
pidgin developers...

Original comment by o...@desire.ch on 7 Jul 2010 at 4:21

• Changed state: Accepted
• Added labels: Milestone-Release0.6.2, Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

Has been added to SVN trunk

Original comment by o...@desire.ch on 8 Jul 2010 at 2:21

• Changed state: FixedOnSVN

[GoogleCodeExporter]

Original comment by o...@desire.ch on 9 Jul 2010 at 3:50

• Changed state: Fixed