Closed schnubor closed 1 year ago
Hey @schnubor, first off thanks for contributing! It is a huge help, the features you added in your last PR were great. I'm going to look a little more closely into this one, mostly just so I don't lose track of where things are but generally I think its a good idea. The repo has grown significantly in size since the project started and issues eat up most of the time I have to sink into it, leaving stuff like organization in the dust.
Again, thanks for the help, will update soon.
Sorry for the slow response here, busy holiday season! I finally got the chance to parse through this and I think everything looks great. Going to merge and move forward with this as a structural starting point for future versions.
Hi!
As mentioned in my previous PR I think it would improve DX a lot if there was a proper project structure instead of having all the src files in just
src
. So here's my suggestion:src
to a separatetest
dir in root -> runningnpm run build
doesn't put.spec
files inlib
jsx
file type and moved them tosrc/components
src/hooks
src/utils
Also updated the Github actions to use Node v16 since
npm i -g npm@latest
was installing npm v9 which is not compatible with Node v12. Also added an.nvmrc
with Node v16 for convenience.Let me know what you think!
Cheers, Christian