search

hxf31891 / react-gradient-color-picker

An easy to use color/gradient picker for React.js
MIT License
147 stars 49 forks source link

EyeDropper doesn't grab the color in firefox #44

Open madisonc33 opened 1 year ago

madisonc33 commented 1 year ago

In firefox, the eyedropper doesn't appear to actually select the color. Seeing https://gradient-package-demo.web.app/ and in own use case

hxf31891 commented 1 year ago

@madisonc33 Firefox (and Safari) have always been an issue for the eyedropper, the browsers aren't compatible with window.eyedropper. I'll take a look.

hxf31891 commented 1 year ago

@madisonc33 I just tested on Firefox 106.0.3, it seems to be working fine. Can you please attach a video of the behavior your getting.

madisonc33 commented 1 year ago

I'm not getting the color even when trying https://gradient-package-demo.web.app/ in firefox but let me update and test a little more to get you more info. Uncaught TypeError: pickerCanvas.getImageData is not a function and Uncaught (in promise) Invalid element provided as first argument are errors I'm seeing

madisonc33 commented 1 year ago

@hxf31891 here is a sandbox where when running firefix I am seeing the same issue - color picker sandbox

if you try to get the color from one of the above boxes, it's not actually updating

Running the same sandbox in chrome works, but not in firefox

hxf31891 commented 1 year ago

@madisonc33 looking into this now, thank you for posting the sandbox.

hxf31891 commented 1 year ago

@madisonc33 unfortunately I still can reproduce. See screen recoding here. Lets get a little more info flowing here. Whats your Firefox version and what are you running on? PC or Mac?

madisonc33 commented 1 year ago

@hxf31891 I'm using Firefox 114.0 (64-bit) on a mac

hxf31891 commented 1 year ago

@madisonc33 I'm perplexed. I am also running 114 on Mac. Are you silicon or Intel? Do you have any security tighter settings on that browser?

madisonc33 commented 1 year ago

@hxf31891 Silicon - just the standard settings are far as I'm aware of

madisonc33 commented 1 year ago

I just tried it on a different computer with intel and it worked when selecting the colors at the top (but not the black font or off the slider) running 114.0.2

hxf31891 commented 1 year ago

@madisonc33 thanks for keeping up with this, I have been praying that the EyeDropper API would be gaining traction with non chromium browsers but it looks like I am not going to get lucky there. I may need to rethink how this works.