This led to segfaults on master when setting a shortcut in the PreferencesDialog and triggering anything which can be undone afterwards.
Since changing the Preferences triggers MainForm::createMenuBar - to update the shown shortcuts - we have to be very careful to enabling/disabling the proper undo/redo actions based on the current stack position.
Also, it is important to only connect these once. Else the property will be set over and over again.
This led to segfaults on
masterwhen setting a shortcut in thePreferencesDialogand triggering anything which can be undone afterwards.Since changing the Preferences triggers
MainForm::createMenuBar- to update the shown shortcuts - we have to be very careful to enabling/disabling the proper undo/redo actions based on the current stack position.Also, it is important to only connect these once. Else the property will be set over and over again.