search

hydrotekfarm / esp32_automation

Other
0 stars 0 forks source link

Ultrasonic sensor - [merged] #25

Closed hydrotekfarm closed 1 year ago

hydrotekfarm commented 4 years ago

Merges ultrasonic-sensor -> master

This branch created functionality for the HC-SR04 ultrasonic sensor along with code tweaks and project restructuring.

hydrotekfarm commented 4 years ago

In GitLab by @AjayKrishna123 on Jun 2, 2020, 22:50

Everything looks good. I have one suggestion. Should we maybe change the publish_data task to mqtt_client? This is because this topic will also be responsible for subscribing to topics in order to receive data coming from the ionic app. So publishing data isn't its only role. Also, you could change the add_sensor_data helper method to publish_data, as that name would be more appropriate for its role.

hydrotekfarm commented 4 years ago

In GitLab by @AjayKrishna123 on Jun 3, 2020, 16:50

We can figure this out in the future.

hydrotekfarm commented 4 years ago

In GitLab by @AjayKrishna123 on Jun 3, 2020, 16:50

merged

hydrotekfarm commented 4 years ago

In GitLab by @AjayKrishna123 on Jun 3, 2020, 16:50

mentioned in commit a25b5ab0d2d7a7ee821471a7fa521ae03392248e