search

hyperjumptech / monika

Monika is a command line application to monitor every part of your web app using a simple YAML configuration file. Get alert not only when your site is down but also when it's slow.
https://monika.hyperjump.tech
MIT License
605 stars 67 forks source link

Fix: The disabled failed probe is not retrying when it encounters an incident after enabling it #1242

Closed haricnugraha closed 9 months ago

haricnugraha commented 9 months ago

Monika Pull Request (PR)

What feature/issue does this PR add

The disabled failed probe is not retrying when it encounters an incident after enabling it.

How did you implement / how did you fix it

Remove incident data when disabling a probe.

How to test

  1. Run in Symon mode
  2. Make the probe target to be down
  3. Disable the probe
  4. Enable the probe

Video

Before (Incident is not reported)

https://github.com/hyperjumptech/monika/assets/15191978/c4111e1b-c605-424a-becc-bf9b3f10663d

After (Incident reported)

https://github.com/hyperjumptech/monika/assets/15191978/1e01abb7-a382-4b73-9273-376691bb24f8

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.58%. Comparing base (a907167) to head (ecdcfe5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1242 +/- ## ========================================== + Coverage 63.49% 63.58% +0.09% ========================================== Files 111 111 Lines 3304 3304 Branches 569 567 -2 ========================================== + Hits 2098 2101 +3 + Misses 1016 1015 -1 + Partials 190 188 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.