search

hyperjumptech / monika

Monika is a command line application to monitor every part of your web app using a simple YAML configuration file. Get alert not only when your site is down but also when it's slow.
https://monika.hyperjump.tech
MIT License
605 stars 67 forks source link

fix(snap) : #1255 fix notification not included in snap binary #1281

Closed syamsudotdev closed 6 months ago

syamsudotdev commented 6 months ago

Monika Pull Request (PR)

This PR resolves #1255

What feature/issue does this PR add

  1. Fix snap package job not including monika notification package

How did you implement / how did you fix it

  1. Extract tarball
  2. Copy package/notification/lib/ content into extracted tarball path
  3. Use extract path as snapcraft's build source

How to test

Prerequisites

Duplicate steps to build snap binary from publish-snap.yml

  1. npm ci --workspaces --if-present
  2. npm run build --workspaces --if-present
  3. npm ci
  4. npm run pack-tarballs
  5. mv dist/monika*.tar.gz dist/monika.tar.gz
  6. tar -zvxf dist/monika.tar.gz -C dist/
  7. cp -vr packages/notification/lib/* dist/monika/packages/notification/
  8. snapcraft
  9. sudo snap install monika*.snap --devmode
  10. Confirm monika bin location by which monika
  11. Copy config from #1255
  12. monika -r 1 image
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.02%. Comparing base (6a29470) to head (a44f4aa). Report is 11 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1281 +/- ## ========================================== + Coverage 62.51% 64.02% +1.50% ========================================== Files 112 108 -4 Lines 3391 3372 -19 Branches 591 572 -19 ========================================== + Hits 2120 2159 +39 + Misses 1079 1032 -47 + Partials 192 181 -11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.