search

hyperjumptech / monika

Monika is a command line application to monitor every part of your web app using a simple YAML configuration file. Get alert not only when your site is down but also when it's slow.
https://monika.hyperjump.tech
MIT License
605 stars 67 forks source link

Fix Docker build on local machines #1305

Closed sapiderman closed 4 months ago

sapiderman commented 4 months ago

Monika Pull Request (PR)

What feature/issue does this PR add

  1. Fixes make docker when command issued
  2. Fixes docker build configuration

How did you implement / how did you fix it

  1. Modify the builder base image to use non-alpine

How to test

  1. issue make docker
  2. or issue docker build -f Dockerfile .

Expect the build to be completed without error and a image is created

  1. Check docker images to check created image.
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.56%. Comparing base (6a29470) to head (b657312). Report is 20 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1305 +/- ## ========================================== + Coverage 62.51% 63.56% +1.04% ========================================== Files 112 109 -3 Lines 3391 3417 +26 Branches 591 583 -8 ========================================== + Hits 2120 2172 +52 + Misses 1079 1059 -20 + Partials 192 186 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sapiderman commented 4 months ago

This is duplicate to https://github.com/hyperjumptech/monika/pull/1304.. will probably close this.