Do not automatically call identity on Android

hyperlab / TiMixpanel

Mixpanel integration for Titanium Mobile

22 stars 12 forks source link

Do not automatically call identity on Android #17

Closed timanrebel closed 9 years ago

timanrebel commented 9 years ago

On Android we always call identify on initWithToken. This should not be done, because of at least two reasons:

Apps might not have the People plan and don't want to call identify
Apps might want to use their own distinct id when calling identify

However, removing it will break current implementations of the module. We can either notify developers via the readme or add a config parameter to initWithToken?

jonatansberg commented 9 years ago

I think adding a notice to the README is enough, especially since we do not make any identify calls automatically on iOS.

timanrebel commented 9 years ago

I forgot about iOS, that is the 3rd reason :)

timanrebel commented 9 years ago

It seems you don't have to call identify at all if you do not wat to assign your own ID (which you probably should do with alias anyway). https://mixpanel.com/help/reference/android#identify

We currently call identify with the distinctId, which does not seem necessary. I'll remove the call, update the README and do a PR.