Open nbayindirli opened 1 month ago
After running, hyperlane core configure
there is double newline at EOF
Typo in "? Enter protocol fee in for protocol fee hook" after running hyperlane core configure
> protocolFee
protocolFee
and interchainGasPaymaster
do not end in Hook
for hyperlane warp config
do not list raw enum string for token type selection, and make sure every option has a description
hl core configure --ism-advanced
:
bold default in ? Select default hook type merkleTreeHook
bold required in ? Select required hook type protocolFee
when running hl core deploy
, include log like "If you do not see your network in the below list, please be sure to run hl config create
beforehand (note: this will eventually be hl registry configure
When there is no HYP_KEY
sourced, let users know at the beginning of the CLI flow
When a deployment plan is presented to a user during hyperlane * deploy
, emit a log with the location of the core config being read
As features have been added to the CLI, certain string/logging patterns have broken or no longer come across professionally.
This semantics issue is to capture the following work first mentioned in this PR, along with any other console-related work for whatever the end-developer will see/experience while interacting with the CLI, and to standardize those practices across the codebase:
hl config create ism
make e.g. "Setting values for chain fuji" more readablehl config create ism
and answeringyes
for "Use existing Hyperlane validators for this chain?",hl deploy core
throws "Error: Missing advanced ISM config for one or more chains:". Need to align verbiage between the two correlated commandshl deploy kurtosis-agent
commandhl deploy kurtosis-agent
(see comment screenshot below)hl deploy kurtosis-agent
flow asks for origin + 2 other chainshl deploy warp
's error log, "Error: No "Warp route deployment config" found in ./configs. Please confirm the path for Warp route deployment config". By default, the CLI writes to folders relative to where its run.
", to just say filename.