hyperledger-archives / aries-framework-go

Hyperledger Aries Framework Go provides packages for building Agent / DIDComm services.
https://wiki.hyperledger.org/display/ARIES/aries-framework-go
Apache License 2.0
239 stars 160 forks source link

fix: ParseCredential handles SD-JWT VCs with _sd_alg in subject #3511

Closed Moopli closed 1 year ago

Moopli commented 1 year ago

Signed-off-by: Filip Burlacu filip.burlacu@securekey.com

codecov[bot] commented 1 year ago

Codecov Report

Merging #3511 (b967fdf) into main (27ea936) will increase coverage by 0.00%. The diff coverage is 89.28%.

:exclamation: Current head b967fdf differs from pull request most recent head 4194594. Consider uploading reports for the commit 4194594 to get more accurate results

@@           Coverage Diff           @@
##             main    #3511   +/-   ##
=======================================
  Coverage   87.70%   87.70%           
=======================================
  Files         351      351           
  Lines       48281    48229   -52     
=======================================
- Hits        42345    42301   -44     
+ Misses       4398     4393    -5     
+ Partials     1538     1535    -3     
Impacted Files Coverage Δ
pkg/doc/verifiable/credential_sdjwt.go 91.46% <78.57%> (-0.88%) :arrow_down:
pkg/doc/verifiable/credential.go 91.14% <100.00%> (+0.14%) :arrow_up:
pkg/doc/sdjwt/issuer/issuer.go 92.13% <0.00%> (-0.15%) :arrow_down:
pkg/doc/verifiable/jws.go 79.06% <0.00%> (ø)
pkg/doc/presexch/definition.go 85.48% <0.00%> (+0.06%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Moopli commented 1 year ago

Closing this for now as we don't need it.