hyperledger-archives / aries-framework-go

Hyperledger Aries Framework Go provides packages for building Agent / DIDComm services.
https://wiki.hyperledger.org/display/ARIES/aries-framework-go
Apache License 2.0
240 stars 161 forks source link

feat: creating SD-JWT from VC will leave subject ID as regular field #3512

Closed Moopli closed 1 year ago

Moopli commented 1 year ago

instead of turning subject ID into an SD field.

Signed-off-by: Filip Burlacu filip.burlacu@securekey.com

codecov[bot] commented 1 year ago

Codecov Report

Merging #3512 (76c292b) into main (66b1eec) will increase coverage by 0.00%. The diff coverage is 93.02%.

@@           Coverage Diff           @@
##             main    #3512   +/-   ##
=======================================
  Coverage   87.70%   87.70%           
=======================================
  Files         351      351           
  Lines       48174    48204   +30     
=======================================
+ Hits        42251    42279   +28     
- Misses       4390     4391    +1     
- Partials     1533     1534    +1     
Impacted Files Coverage Δ
pkg/doc/verifiable/credential.go 91.00% <75.00%> (-0.32%) :arrow_down:
pkg/controller/webnotifier/webhook.go 93.75% <100.00%> (+0.27%) :arrow_up:
pkg/doc/sdjwt/common/common.go 92.50% <100.00%> (+0.19%) :arrow_up:
pkg/doc/sdjwt/issuer/issuer.go 92.13% <100.00%> (+0.46%) :arrow_up:
pkg/doc/verifiable/credential_sdjwt.go 92.34% <100.00%> (+0.09%) :arrow_up:
pkg/client/legacyconnection/client.go 91.66% <0.00%> (+0.41%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.