hyperledger-archives / aries-framework-go

Hyperledger Aries Framework Go provides packages for building Agent / DIDComm services.
https://wiki.hyperledger.org/display/ARIES/aries-framework-go
Apache License 2.0
240 stars 161 forks source link

chore: Add interop test for verifier #3520

Closed sandrask closed 1 year ago

sandrask commented 1 year ago

Add interop tests for verifier - this is also to prove that we will not have issues with json libraries for interop (string hardening vs. canonicalization note in spec).

Since disclosures are created by the issuer the value can be influenced by marshalling (e.g. spaces, map order etc.) however it will not influence functionality since we are not supposed to re-create disclosures at any point.

Closes #3518

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

codecov[bot] commented 1 year ago

Codecov Report

Merging #3520 (f359435) into main (27ea936) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3520   +/-   ##
=======================================
  Coverage   87.70%   87.70%           
=======================================
  Files         351      351           
  Lines       48281    48286    +5     
=======================================
+ Hits        42345    42350    +5     
  Misses       4398     4398           
  Partials     1538     1538           
Impacted Files Coverage Δ
pkg/doc/sdjwt/verifier/verifier.go 90.62% <100.00%> (+0.21%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.