hyperledger-archives / indy-sdk

indy-sdk
https://wiki.hyperledger.org/display/indy
Apache License 2.0
669 stars 736 forks source link

Add a podspec for objective-c indy wrapper in non-binary distribution #2442

Closed conanoc closed 9 months ago

conanoc commented 3 years ago

Signed-off-by: conanoc conanoc@gmail.com

Previous podspec libindy-objc.podspec has several issues:

Source based podspec would be more convenient because we do not have to prepare binaries and there is no version dependency for swift. Some notes about this commit:

WadeBarnes commented 2 years ago

A fix for the build issues has been implemented (https://github.com/hyperledger/indy-sdk/pull/2470). Please rebase this PR on the latest from the main branch so it is no longer blocked by the related build issues.

conanoc commented 2 years ago

@WadeBarnes After the rebase, build-image-wrapper-base is failing. Any idea?

WadeBarnes commented 2 years ago

@WadeBarnes After the rebase, build-image-wrapper-base is failing. Any idea?

@conanoc, I missed updating the Rust version in a spot; https://github.com/hyperledger/indy-sdk/pull/2475. You won't need to rebase again since the GHA workflows do not block the ability to merge.

WadeBarnes commented 2 years ago

@mirgee, Is this something you could review?