hyperledger-archives / indy-sdk

indy-sdk
https://wiki.hyperledger.org/display/indy
Apache License 2.0
666 stars 737 forks source link

Param confusing in python wrappers #2548

Closed 6U-U9 closed 7 months ago

6U-U9 commented 2 years ago

I was read the python wrappers (indy-sdk/wrappers/indy/ledger.py), and I was confused by the param name and its explanation. I think xhash should be the requested attribute hash and raw should be the attribute name. I wonder whether the param order is wrong when calling the function or it's just a mistake in the comment. Please fix it, thanks.

async def build_get_attrib_request(submitter_did: Optional[str],
                                   target_did: str,
                                   raw: Optional[str],
                                   xhash: Optional[str],
                                   enc: Optional[str]) -> str:
    """
    Builds a GET_ATTRIB request. Request to get information about an Attribute for the specified DID.
    :param submitter_did: (Optional) DID of the read request sender (if not provided then default Libindy DID will be used).
    :param target_did: Target DID as base58-encoded string for 16 or 32 bit DID value.
    :param xhash: (Optional) Requested attribute name.
    :param raw: (Optional) Requested attribute hash.
    :param enc: (Optional) Requested attribute encrypted value.
    :return: Request result as json.
    """
kidflux2022 commented 2 years ago

Did you try changing those issues? And did it work?