Fix server dependency in FakePeer; fix timer thread in YAC - Githubissues

hyperledger-iroha / iroha-dco

Iroha - A simple, decentralized ledger

http://iroha.tech

Apache License 2.0

988 stars 297 forks source link

Fix server dependency in FakePeer; fix timer thread in YAC #2218

Closed lebdron closed 5 years ago

lebdron commented 5 years ago

Description of the Change

Fix cyclic dependency in Behavior and FakePeer when it was possible for gRPC server and services to deadlock on destruction
Fix thread management in Yac TimerImpl. Now a single thread is used for all invocations, and thread is destroyed together with TimerImpl class.

Benefits

No random segfaults and locks in fake_peer_example_test

Possible Drawbacks

None

Usage Examples or Tests

fake_peer_example_test, yac_timer_test