Closed Xilis closed 2 years ago
@Xilis 4.9.4
would be nice
@AlexandrouR any chance we can get this merged?
bumped to 4.9.4
you can force the dependency version of the plugin directly, like the following in your pom.xml
, until this is merged
...
<plugin>
<groupId>org.web3j</groupId>
<artifactId>web3j-maven-plugin</artifactId>
<version>4.8.7</version>
<executions>
<execution>
<id>generate-sources</id>
<phase>generate-sources</phase>
<goals>
<goal>generate-sources</goal>
</goals>
</execution>
</executions>
<dependencies>
<dependency>
<groupId>org.web3j</groupId>
<artifactId>core</artifactId>
<version>4.9.4</version>
</dependency>
<dependency>
<groupId>org.web3j</groupId>
<artifactId>codegen</artifactId>
<version>4.9.4</version>
</dependency>
</dependencies>
...
I will review the pending PRs today and bump the project.
What does this PR do?
Updates the underlying web3j dependency to 4.9.4.
Where should the reviewer start?
Not much to look at :P
https://github.com/web3j/web3j/releases/tag/v4.9.2 mentions multiple generator related fixes, for example, https://github.com/web3j/web3j/pull/1647
Why is it needed?
The updates done to web3j since 4.8.7 include multiple fixes to the wrapper generation, and thus by just updating the dependency a lot of related issues are resolved.