search

hyperledger / anoncreds-rs

anoncreds-rs
https://wiki.hyperledger.org/display/anoncreds
Apache License 2.0
74 stars 55 forks source link

AnonCreds Credentials using the W3C Standard - wrappers #273

Closed Artemkaaas closed 10 months ago

Artemkaaas commented 1 year ago
Artemkaaas commented 11 months ago

@TimoGlastra I processed and resolved comments connected to using W3c instead W3C. I will handle the rest of comments (relating to credential-offer/request duplication and credential methods for non-anoncreds proof) after discuss at the WG call. Unfortunately, I may miss today's call due to some personal errands.

TimoGlastra commented 11 months ago

@Artemkaaas once #291 is merged, I'll take another look at this PR, but there's currently too much different changes

swcurran commented 10 months ago

The plan (per requests from @TimoGlastra and @andrewwhitehead ) is to merge #273 first (once the test failure is fixed), so this is easier to check. Tests are passing here, so hopefully this one will be easy to approve once #273 is merged.

FYI @Artemkaaas

Thanks

swcurran commented 10 months ago

@TimoGlastra , @andrewwhitehead -- can you please do a review of this PR. The other two have been merged, so this should be easier to review. Thanks.

andrewwhitehead commented 10 months ago

Looks good, with a couple tiny notes. We'll want to add the w3c tests to the CI.

TimoGlastra commented 10 months ago

Also one more question/ : did you test the react native code already? Or should we do some Testing in react native?

Artemkaaas commented 10 months ago

Also one more question/ : did you test the react native code already? Or should we do some Testing in react native?

I only checked build and compile scripts for wrapper, but not tested integration into a react-native application.

TimoGlastra commented 10 months ago

Also one more question/ : did you test the react native code already? Or should we do some Testing in react native?

I only checked build and compile scripts for wrapper, but not tested integration into a react-native application.

We can do that once this is merged and released as dev 👍