search

hyperledger / anoncreds-rs

anoncreds-rs
https://wiki.hyperledger.org/display/anoncreds
Apache License 2.0
74 stars 55 forks source link

AnonCreds Credentials using the W3C Standard - proof value encoding #276

Closed Artemkaaas closed 10 months ago

Artemkaaas commented 1 year ago

Use message pack for encoding proof values of w3c credentials and presentation. Results of proof value string length on example of credentials signature:

andrewwhitehead commented 10 months ago

Tests are failing because a Rust dependency now requires 1.66 or higher. We can either update the CI rust version or add a lockfile in another PR.

swcurran commented 10 months ago

Seems like updating would be the prudent thing? What is typically done in this situation? How much risk is bumping the rust version? As I recall — the. #295 is failing one test (Android) because it needs 1.70. Should we bump to that?

andrewwhitehead commented 10 months ago

There's no real risk in bumping the Rust version used, it just means that we can't guarantee compatibility with older versions. I think the Android failure is different (one of cross's dependencies), and partly fixed by this PR, but it would eventually need a lockfile to maintain its platform support.

swcurran commented 10 months ago

OK — just trying to figure out how we get to a decision/action on this. Who makes the call?

TimoGlastra commented 10 months ago

@berendsliedrecht just checking if this can impose a problem for the supported versions of the RN wrapper if the version is bumped?

swcurran commented 10 months ago

@Artemkaaas --- sorry to be a pain. Looks like we have one unit test failing. Could you please take a look?

test data_types::w3c::proof::tests::encoded_object_encode_decode_works ... FAILED

Fails on both Ubuntu and Windows.