hyperledger / aries-rfcs

Hyperledger Aries is infrastructure for blockchain-rooted, peer-to-peer interactions
https://hyperledger.github.io/aries-rfcs/
Apache License 2.0
326 stars 217 forks source link

using BTreeMap #781

Closed Parikalp-Bhardwaj closed 1 year ago

Parikalp-Bhardwaj commented 1 year ago

Use a HashMap when:

You want to associate arbitrary keys with an arbitrary value.

You want a cache.

You want a map, with no extra functionality.

Use a BTreeMap when:

You're interested in what the smallest or largest key-value pair is.

You want to find the largest or smallest key that is smaller or larger than something.

You want to be able to get all of the entries in order on-demand.

You want a map sorted by its keys

swcurran commented 1 year ago

This PR cannot be merged while failing the checks — notably DCO (DCO - Developer Certificate of Origin - https://github.com/apps/dco). While an interesting change, AFAIK, it doesn’t change the behaviour.

Closing. Please reopen if you think I’m missing the point.

Parikalp-Bhardwaj commented 1 year ago

@swcurran can you check this