search

hyperledger / aries-rfcs

Hyperledger Aries is infrastructure for blockchain-rooted, peer-to-peer interactions
https://hyperledger.github.io/aries-rfcs/
Apache License 2.0
326 stars 217 forks source link

Update the 'unresolved questions' section of the 0317-please-ack RFC #801

Closed alexsdsr closed 8 months ago

alexsdsr commented 1 year ago

This PR adds one more 'unresolved question' to the 0317-please-ack RFC.

alexsdsr commented 12 months ago

Hello @swcurran

Could you please review this PR or assign someone as a reviewer? Thank you

swcurran commented 11 months ago

Sorry for the delay. We did talk about this on the Aries Working Group call and I’ll get back to you with feedback from the group.

swcurran commented 8 months ago

The Aries Community is removing please_ack from AIP 2.0 and retiring the please_ack protocol in https://github.com/hyperledger/aries-rfcs/pull/814 that should be merged Real Soon Now. In that PR, links are provided to the PRs done here (but not merged) to provide extra details as to why the protocol is being retired — because a “general purpose” please_ack feature is not viable and if wanted, MUST be part of each protocol.

Thanks again for the work, @alexsdsr. Even though it didn’t get merged we learned a lot from this and moved DIDComm forward. The biggest learning is to make sure that we don’t “throw in” cross-cutting or optional features that alter the protocols state machines. For example — as recently come up — throwing in an optional, extra “problem-report” in response to a flawed final message of a protocol breaks the state machine. Either the extra message MUST be made every time, or not ever made — not sometimes...