Refactor test-network post-decoupling fabric-tools image

satota2 commented 7 months ago

This patch aims to refactor the test-network in several aspects, the initial PR (#1186) for the decoupling of the fabric-tools image from fabric-samples.

For context, please refer to the discussions on that PR.

Rename 'test_network_home' env var to 'TEST_NETWORK_HOME'
Dedicate the intermediate artifacts related to configtx to channel-artifacts
Refer to core.yaml in fabric-samples/config, similar to org1 and 2, instead of adding a new core file
Remove unnecessary functions and comments for CLI container
Other minor modifications

Related Issues:

https://github.com/hyperledger/fabric-samples/pull/1186

satota2 commented 7 months ago

@Mergifyio rebase

mergify[bot] commented 7 months ago

rebase

❌ Unable to rebase: user `satota2` is unknown.

Please make sure `satota2` has logged in Mergify dashboard.

satota2 commented 7 months ago

Hello @denyeart, I have rebased the PR and ensured all tests pass. Could you please review and merge it at your convenience? Thank you.

denyeart commented 7 months ago

Thank you @SamYuan1990 and @satota2 , apologies for the delay!

satota2 commented 7 months ago

@denyeart Thank you for reviewing and merging the pull request.

hyperledger / fabric-samples